Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Replace library interface with EUI version #102758

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[Workplace Search] Replace library interface with EUI version #102758

merged 1 commit into from
Jun 21, 2021
+2 −2

Conversation

scottybollinger
Copy link
Contributor

Summary

One of the Workplace Search components was using the 'react-beautiful-dnd' typing for its component. This PR replaces it with the EUI equivalent. Part of #102689

@scottybollinger
[Workplace Search] Replace library interface with EUI
e5b0dc2 
One of the Workplace Search components was using the 'react-beautiful-dnd' typing for it’s component. This PR relpaces it with the EUI equivalent.
@scottybollinger scottybollinger added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2021
@scottybollinger scottybollinger requested a review from a team June 21, 2021 15:08
@scottybollinger scottybollinger mentioned this pull request Jun 21, 2021
Open
@scottybollinger scottybollinger changed the title [Workplace Search] Replace library interface with EUI [Workplace Search] Replace library interface with EUI version Jun 21, 2021
cee-chen
cee-chen approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this Scotty! 💯

@scottybollinger scottybollinger enabled auto-merge (squash) June 21, 2021 15:36
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 49271f3 into elastic:master Jun 21, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@scottybollinger @kibanamachine
[Workplace Search] Replace library interface with EUI (elastic#102758)
469db4d 
One of the Workplace Search components was using the 'react-beautiful-dnd' typing for it’s component. This PR relpaces it with the EUI equivalent.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 21, 2021
@kibanamachine @scottybollinger
[Workplace Search] Replace library interface with EUI (#102758) (#102776
9f1adeb 
)

One of the Workplace Search components was using the 'react-beautiful-dnd' typing for it’s component. This PR relpaces it with the EUI equivalent.

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
@scottybollinger scottybollinger deleted the scottybollinger/rdnd-type branch June 24, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottybollinger @kibanamachine @cee-chen